Question attributes redesign - Revision history

C schmitz: Text replacement - "ExpressionManager" to "ExpressionScript Engine"

2020-02-11T13:40:09Z

Text replacement - "ExpressionManager" to "ExpressionScript Engine"

← Older revision		Revision as of 15:40, 11 February 2020
Line 54:		Line 54:
	* Question class is clearly a Theme related attribute. Not linked to specific question [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* Question class is clearly a Theme related attribute. Not linked to specific question [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
	* Can we remove timer attribute from core please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js) [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* Can we remove timer attribute from core please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js) [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
	* All expression part (min value , max number) are done in ~~LimeExpressionManager~~ : totally unrelated to QuestionTheme [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* All expression part (min value , max number) are done in LimeExpressionScript Engine : totally unrelated to QuestionTheme [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])

DenisChenu: /* Scenarios */

2020-02-03T17:16:53Z

Scenarios

← Older revision		Revision as of 19:16, 3 February 2020
Line 43:		Line 43:

	In QuestionTemplate.php https://github.com/LimeSurvey/LimeSurvey/commit/b34f839d202ba0061412b5bd313d08e1d34d3309 yes, but not in QuestionAttribute https://github.com/LimeSurvey/LimeSurvey/blob/1891591465f646c51eac8ff4523e91c6343b1d68/application/models/QuestionAttribute.php#L253-L260, then need to remind this point.		In QuestionTemplate.php https://github.com/LimeSurvey/LimeSurvey/commit/b34f839d202ba0061412b5bd313d08e1d34d3309 yes, but not in QuestionAttribute https://github.com/LimeSurvey/LimeSurvey/blob/1891591465f646c51eac8ff4523e91c6343b1d68/application/models/QuestionAttribute.php#L253-L260, then need to remind this point.

			[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 18:16, 3 February 2020 (CET)

	== Notes ==		== Notes ==

DenisChenu: /* Scenarios */

2020-02-03T17:16:37Z

Scenarios

← Older revision		Revision as of 19:16, 3 February 2020
Line 40:		Line 40:

	[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:41, 3 February 2020 (CET)		[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:41, 3 February 2020 (CET)


			In QuestionTemplate.php https://github.com/LimeSurvey/LimeSurvey/commit/b34f839d202ba0061412b5bd313d08e1d34d3309 yes, but not in QuestionAttribute https://github.com/LimeSurvey/LimeSurvey/blob/1891591465f646c51eac8ff4523e91c6343b1d68/application/models/QuestionAttribute.php#L253-L260, then need to remind this point.

	== Notes ==		== Notes ==

Olle: /* Scenarios */

2020-02-03T16:41:20Z

Scenarios

← Older revision		Revision as of 18:41, 3 February 2020
Line 36:		Line 36:

	[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:38, 3 February 2020 (CET)		[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:38, 3 February 2020 (CET)

			OK, good point. That's not how it works now?

			[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:41, 3 February 2020 (CET)

	== Notes ==		== Notes ==

DenisChenu: /* Scenarios */

2020-02-03T16:38:31Z

Scenarios

← Older revision		Revision as of 18:38, 3 February 2020
Line 33:		Line 33:
	[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:31, 3 February 2020 (CET)		[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:31, 3 February 2020 (CET)

	For twig : is better to have a single language … {{ Question.i18attribute }} and not {{ Question.i18attribute[????] }}		For twig : is better to have a single language … <nowiki>{{ Question.i18attribute }}</nowiki> and not <nowiki>{{ Question.i18attribute[????] }}</nowiki>

	[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:38, 3 February 2020 (CET)		[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:38, 3 February 2020 (CET)

DenisChenu: /* Scenarios */

2020-02-03T16:38:01Z

Scenarios

← Older revision		Revision as of 18:38, 3 February 2020
Line 32:		Line 32:

	[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:31, 3 February 2020 (CET)		[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:31, 3 February 2020 (CET)

			For twig : is better to have a single language … {{ Question.i18attribute }} and not {{ Question.i18attribute[????] }}

			[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:38, 3 February 2020 (CET)

	== Notes ==		== Notes ==

Olle: /* Scenarios */

2020-02-03T16:31:14Z

Scenarios

← Older revision		Revision as of 18:31, 3 February 2020
Line 24:		Line 24:
	* Load question attributes for question type/question id for a single language (for qanda/QuestionTheme and SurveyTheme)		* Load question attributes for question type/question id for a single language (for qanda/QuestionTheme and SurveyTheme)
	* …		* …

			---

			> Load question attributes for question type/question id for a single language (for qanda/QuestionTheme and SurveyTheme)

			If you already can load for ''all'' languages, you don't have to load for ''one'' language, IMO. Unless the number of languages are > 20, which I don't think happens very often...? Also, this is done via lazy loading through the ORM. I think. (Unless explicitly loading it eagerly.)

			[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:31, 3 February 2020 (CET)

	== Notes ==		== Notes ==

DenisChenu: /* Notes */

2020-02-03T16:22:51Z

Notes

← Older revision		Revision as of 18:22, 3 February 2020
Line 28:		Line 28:

	TODO		TODO

			== Future evolution and remark ==

			* Question class is clearly a Theme related attribute. Not linked to specific question [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
			* Can we remove timer attribute from core please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js) [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
			* All expression part (min value , max number) are done in LimeExpressionManager : totally unrelated to QuestionTheme [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])

DenisChenu: /* Scenarios */

2020-02-03T16:22:06Z

Scenarios

← Older revision		Revision as of 18:22, 3 February 2020
Line 17:		Line 17:
	== Scenarios ==		== Scenarios ==

	~~All use-cases go here.~~		* Get potential question attribute from core

	* ~~Question class is clearly a Theme related attribute. Not linked to specific~~ question
	* Can we remove timer attribute from core ~~please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js)~~
	* All expression part (min value , max number) are done in LimeExpressionManager : totally unrelated to QuestoinTheme

	~~---~~

	~~I was thinking basically all use-cases can be summarized to:~~

	* Import question attribute from XML/question theme		* Import question attribute from XML/question theme
	* Save question attribute value		* Add (replace ?) question attribute from plugins
			* Save question attribute value (for all language or not)
	* Load question attributes for question type/question id		* Load question attributes for question type/question id
			* Load question attributes for question type/question id for a single language (for qanda/QuestionTheme and SurveyTheme)
	~~[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:14, 3 February 2020 (CET)~~		* …

	~~Question~~ attributes ~~'''redesign''' : redesign is redesing.~~

	~~If you talk of re design : must be~~ a ~~real redesign . I move my previous comment to Notes :~~) ~~in next edition~~

	~~[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:19, 3 February 2020 (CET)~~

	== Notes ==		== Notes ==

	TODO		TODO

DenisChenu: /* Scenarios */

2020-02-03T16:19:44Z

Scenarios

← Older revision		Revision as of 18:19, 3 February 2020
Line 32:		Line 32:

	[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:14, 3 February 2020 (CET)		[[User:Olle\|Olle]] ([[User talk:Olle\|talk]]) 17:14, 3 February 2020 (CET)

			Question attributes '''redesign''' : redesign is redesing.

			If you talk of re design : must be a real redesign . I move my previous comment to Notes :) in next edition

			[[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]]) 17:19, 3 February 2020 (CET)

	== Notes ==		== Notes ==

	TODO		TODO

← Older revision		Revision as of 15:40, 11 February 2020
Line 54:		Line 54:
	* Question class is clearly a Theme related attribute. Not linked to specific question [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* Question class is clearly a Theme related attribute. Not linked to specific question [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
	* Can we remove timer attribute from core please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js) [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* Can we remove timer attribute from core please ! https://manual.limesurvey.org/Question_type_-_Short_free_text#Timer : remind : Not only for on,e question, didn't update any HTML/CSS part (only js) [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])
	* All expression part (min value , max number) are done in ~~LimeExpressionManager~~ : totally unrelated to QuestionTheme [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])		* All expression part (min value , max number) are done in LimeExpressionScript Engine : totally unrelated to QuestionTheme [[User:DenisChenu\|DenisChenu]] ([[User talk:DenisChenu\|talk]])