Check out the LimeSurvey source code on GitHub!
Welcome, Guest
Username: Password:

TOPIC: LimeSurvey1.92RC1 is released

Aw: LimeSurvey1.92RC1 is released 4 years 6 months ago #71591

  • DenisChenu
  • DenisChenu's Avatar
  • Online
  • Moderator Lime
  • Posts: 9264
  • Thank you received: 1321
  • Karma: 383
TMSWhite wrote:
Shnoulle wrote:
Something: it's look like we don't have help text on tthe 1.92+ example, it work on the 1.90..

I look tomorrow to do a bug report ;).

Shnoulle, no need for that bug report. That issue has already been fixed.

Of course, if you find anything new, please submit a bug report.

/Tom
Yep, I made another error too ... look for more ;)
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71595

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
flocs, how would you use a "this" selector for tailoring?

For use within templates, the easiest solution would be to create new substitution variables like QUESTION_XXXX, where XXXX are each of the new EM-related attributes.

Or, is the thought that you would have a lot of similar questions and using "this" would avoid the need to modify the question text?
Last Edit: 4 years 6 months ago by TMSWhite.
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71598

  • floccs
  • floccs's Avatar
  • Offline
  • Senior Lime
  • Posts: 47
  • Thank you received: 5
  • Karma: 2
TMSWhite wrote:
Or, is the thought that you would have a lot of similar questions and using "this" would avoid the need to modify the question text?

I think it is useful especially when using javascript workaround to extend capability of questions. I know that EM will make a lot of javascript workaround useless, but in some case a kind of this selector would be convenient. I'm thinking about some questions I've created in a survey (e.g. Track respondents answers across multiple surveys or an image selection question) that could be reused without any modifications if this exists
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71600

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
flocs-

Having a "this" variable for simple questions would probably be do-able. However, how would you want to refer to (e.g. create names for) questions that have sub-questions? Or, would you want "this" to refer to each sub-question as it is processed?

If you can provide some sample code that would use "this", I can think through this in more detail.

/Tom
The administrator has disabled public write access.

Aw: LimeSurvey1.92RC1 is released 4 years 6 months ago #71643

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

I tried to test the EM and condition to relevance conversion and it seems to work fine with our survey (which seems to be slow in 1.91+ because of its 11 conditions in one matrix question). The relevance now looks like
((BEW_1_0 > "3")) or ((BEW_2_0 > "3")) or ((BEW_3_0 > "3")) or ((BEW_4_0 > "3")) or ((BEW_5_0 > "3")) or ((BEW_6_0 > "3")) or ((BEW_7_0 > "3")) or ((BEW_8_0 > "3")) or ((BEW_9_0 > "3")) or ((BEW_10_0 > "3")) or ((BEW_11_0 > "3"))
and should be the same as the conditions we set in 1.91+.
Though it would be interessting to see if it's really much faster. But I can't test that at the moment.
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71668

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

I tested a survey using "&newtest=Y". I stoped at the second page, then started the survey. I then used the link without "&newtest=Y" but was sent to the second page and got the message:
"Please use the LimeSurvey navigation buttons or index. It appears you attempted to use the browser back button to re-submit a page."
After a click on okay I answerd the question and clicked on the "next" button. I then came out the welcome page of my survey.
It seems there is a problem to differentiate between normal survey participation and test mode.

Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71675

  • Mazi
  • Mazi's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 5974
  • Thank you received: 366
  • Karma: 260
[quote="vierundzwanzig" post=71668
It seems there is a problem to differentiate between normal survey participation and test mode.
[/quote]
This sounds to be worth a bug ticket :cheer:

Best regards/Beste Grüße,
Dr. Marcel Minke
(Limesurvey Head of Support)
Need Help? We offer professional Limesurvey support
Contact: marcel.minke(at)limesurvey.org'"
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71696

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Mazi wrote:
[quote="vierundzwanzig" post=71668
It seems there is a problem to differentiate between normal survey participation and test mode.
This sounds to be worth a bug ticket :cheer:[/quote]

reported:
bugs.limesurvey.org/view.php?id=5656
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71727

  • DenisChenu
  • DenisChenu's Avatar
  • Online
  • Moderator Lime
  • Posts: 9264
  • Thank you received: 1321
  • Karma: 383
Hello,

With 1.91+, we have the opportunity to use focusfist function, but now this is in LEMsetTabIndexes function, we have $(this).focus(); .

I think it's not a good idea to have an automatic focusfirst function, can we remove it ?

Denis

PS: there are a problem for ranking question and input Index, but in 1.91+ too.
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71736

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
vierundzwanzig and Mazi-

The "newtest" issue is an artifact of how I'm handling sessions to keep a person from submitting the same page twice. I create a random number and send it in the HTML, plus store it in the $_SESSION. If you submit a page that doesn't have the same number, then you might have had two windows open, or clicked the browser back button, or other reasons.

This is not the most elegant solution. Yii will have better session handling which will obviate the problem.

Sounds like I just need to detect when "newtest" is passed on the command line and have the functions that look for the random number ignore it.

/Tom
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71737

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
Shnoulle-

LEMsetTabindexes() is no longer called - I should remove it. It uses JQuery to find the first :input item and calls $(this).focus() to focus on it.

Using focusfirst() would be fine. Looks like it does

$('#limesurvey :input:visible:enabled:first').focus();

so it is more accurate than what I was doing (which just looked at :input:enabled)

/Tom
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71739

  • DenisChenu
  • DenisChenu's Avatar
  • Online
  • Moderator Lime
  • Posts: 9264
  • Thank you received: 1321
  • Karma: 383
TMSWhite wrote:
Shnoulle-

LEMsetTabindexes() is no longer called - I should remove it. It uses JQuery to find the first :input item and calls $(this).focus() to focus on it.

Using focusfirst() would be fine. Looks like it does

$('#limesurvey :input:visible:enabled:first').focus();

so it is more accurate than what I was doing (which just looked at :input:enabled)

/Tom
I use rev 11987, and if i comment the $(this).focus();, i don't have the focus on firt input.

And i think
1. focus first have to be optionnal
2. focus first only on text/textarea question.

Denis
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71742

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
Shnoulle-

Would you recommend that as a global and/or survey-specific setting? Personally, I like having the auto-focus on the first question on the page (or the first question that fails mandatory or validation rules). I try to avoid using the mouse, so like to be able to immediately answer from the keyboard and/or tab to the proper question, and without focusfirst(), each browser focuses in inconsistent places.
If we make this a setting, we can give users several choices.

/Tom
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71744

  • DenisChenu
  • DenisChenu's Avatar
  • Online
  • Moderator Lime
  • Posts: 9264
  • Thank you received: 1321
  • Karma: 383
TMSWhite wrote:
Shnoulle-

Would you recommend that as a global and/or survey-specific setting? Personally, I like having the auto-focus on the first question on the page (or the first question that fails mandatory or validation rules). I try to avoid using the mouse, so like to be able to immediately answer from the keyboard and/or tab to the proper question, and without focusfirst(), each browser focuses in inconsistent places.
If we make this a setting, we can give users several choices.

/Tom
Don(t know really,

First global, and if user ask : put in survey ;).

Denis
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
The administrator has disabled public write access.

LimeSurvey1.92RC1 is released 4 years 6 months ago #71767

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

are there any checks if the survey logic is correct and are there places in LimeSurvey where you show the results of this check?
I know you can check it yourself if you just call the logic function for the survey, group, or question. But I thought about the following cases.

1. Importing a survey
I imported a few surveys and the overview page after the import told me everything is okay. I checked the survey logic, there seems to be some errors that occur because e.g. the question code doesn't match the requirements/rules (e.g. if the code is only a number like "1" or you have a "-" like "Verb-Vors" in your code). So I think it might be an idea to check if there are logic problems with the survey after importing and view a hint like "Your survey logic contains x errors. If you have problems click here to view the survey logic." if something is wrong.

2. Creating/Editing a question
I renamed the code "Verb-Vors" to "VerbVors" to solve the error mentioned on the logic page. I then tried to rename it back to "Verb-Vors" and created this error on purpose. So I think it might be an idea to check if there's something wrong with the question and show a hint (or even stop and let the user correct their mistakes) that something is wrong with the logic. I don't think it would be to difficult to do a regex check for the Code input field and prevent the user from entering something that doesn't meet the requirements/rules.

3. Upgrading LimeSurvey
If 1.92 is released we might get come to the point where users upgrade their installation. We don't know what might happen if after the upgrage certain survey have errors/problems and don't tell the user about the problems.

4. Show logic status on survery information page
There's a page for each survey where you get the survey link, administrator name, used template, ... . Perhaps it might be an idea to create a global option "Show logic status on overview page" that lets you show a status like "OK", "2 errors" or something simmilar. I think it should be an option to add this because it can happen that some people don't really want to see it (e.g. the customer creating a survey. If you show something like "2 errors" he might get irritated and call me/tell me "Mr. X, there are problems with my survey *sigh, sigh, sigh*").
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.
Time to create page: 0.315 seconds
Imprint                   Data Protection Statement                  Revocation information and revocation form