Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

More
8 months 6 days ago #148805 by oleggorfinkel
oleggorfinkel created the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
Hi,

Yesterday, I used LimeSurvey to administer a lot of questionnaires out in the field and discovered a fairly serious bug -- for many users on mobile devices, survey and section titles appear cut off by the title bar, so the user can't even tell which section they are working on. I have just submitted a bug report for this: bugs.limesurvey.org/view.php?id=12137

The problem for me now is that I'll have to run the survey again tomorrow, with even more users, and I have to do something quickly to avoid this happening again. Fortunately, I had saved my entire previous installation of XAMPP before updating, so that would be fairly easy to roll back, but with a remote server mirror I have running on a hosting provider's server, it won't be so easy, will it (since I can't easily replace the database). I know that when I updated from the previous version (2.5+ build 160812), the database was upgraded, so I don't imagine I can just swap in the contents of the htdocs directory, can I?

Or, perhaps, it's a simple fix, and a new version could be put out quickly... What would you recommend that I do?

Please Log in to join the conversation.

More
8 months 6 days ago #148806 by jelo
jelo replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
I would mention the template used.
Are you 100% sure that you didn't had these optical glitches in an earlier version/build of LimeSurvey as well?
To me this looks like the typical bootstrap hell.
See this bug report from Oct 2016
bugs.limesurvey.org/view.php?id=11820

Please Log in to join the conversation.

More
8 months 6 days ago #148807 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

jelo wrote: I would mention the template used.
Are you 100% sure that you didn't had these optical glitches in an earlier version/build of LimeSurvey as well?
To me this looks like the typical bootstrap hell.
See this bug report from Oct 2016
bugs.limesurvey.org/view.php?id=11820


Hi, Jelo, thanks for replying.

I am absolutely sure the previous version didn't have this issue.

I am using the same template as before -- a slightly tweaked version of the Default template (basically exactly the same, but with my own graphic). You can have a look at it here: apuv.tentokai.com .

The other bug report you mentioned refers to text disappearing behind the progress bar. In my case, it is being cut off underneath the TITLE bar (on my surveys, the progress bar is disabled). So, I am not sure this other bug is at all similar to mine...

Any suggestions on how to roll back to the previous version safely? I am worried I don't have time for any other solution, as tomorrow I'll have to administer these surveys to a hundred people... Thanks!

Please Log in to join the conversation.

More
8 months 6 days ago #148808 by jelo
jelo replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

oleggorfinkel wrote:

jelo wrote: I am absolutely sure the previous version didn't have this issue.

Are you sure it was tested back then with the same chrome mobile browser (same version/build)?

I cannot reproduce the issue with the first page of the survey. But I haven only used some simulators.

I cannot recommend to rollback the whole installation without knowing the exact issue causing this overlapping.

I would first try to use a "unmodified" template which was shipped with the LS update to rule out template issues introduced by using an modified template, which isn't getting bug-fixes when LS is updated.

I then would try to get some mobile browser and try to modify the question-text and the template to see if I can improve the situation. If the issue is related to chrome a complete rollback of the Limesurvey installation would be waste of time.

The following user(s) said Thank You: oleggorfinkel

Please Log in to join the conversation.

More
8 months 6 days ago - 8 months 6 days ago #148817 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

jelo wrote:

oleggorfinkel wrote:

jelo wrote: I am absolutely sure the previous version didn't have this issue.


I would first try to use a "unmodified" template which was shipped with the LS update to rule out template issues introduced by using an modified template, which isn't getting bug-fixes when LS is updated.


It WAS a problem with the template -- thanks! And now I understand how this came about: when updating LimeSurvey to the latest version, I did as the manual suggests -- replaced all the files EXCEPT application/config/config.php and the "upload" directory. My customized template, of course, was sitting in the upload directory. So, by the looks of it, custom templates can't just be carried forward to each new version without a refresh. I guess, from now on, every time I upgrade, I'll have to take the new "default" template and customize it with my changes, correct? This is what I did just now, and it worked!

I have one question left, then: is there anything else under the upload directory, apart from any custom templates, that needs to be refreshed with every new upgrade?
Last Edit: 8 months 6 days ago by oleggorfinkel.

Please Log in to join the conversation.

More
8 months 6 days ago #148820 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
I have just added the following text to the "Upgrading from a previous version" section of the manual, to make sure other people won't make the same mistake as I did when updating to a new version:

(NOTE: If you have any customized templates sitting under /upload/templates, make sure you refresh those with any changes from the new version. The easiest way to check for such changes is to file-compare your old template with the new version of the default template, and if you see any differences other than your customizations, a refresh is needed.)

Please Log in to join the conversation.

More
8 months 6 days ago #148821 by holch
holch replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
The step to refresh your template is only necessary if there has been a change in the templating system, otherwise your other template should work fine.

There was quite a big "break" in templates from the 2.05 (now 2.5) to the 2.5x version of Limesurvey. So if you upgraded from the 2.05 branch to the 2.5x branch, then yes, this is definitely true. if it was from a version of 2.5x to 2.5x, there should be no need to update your templates I think.

I'm not a LimeSurvey GmbH member. I answer at the LimeSurvey forum in my spare time. No support via private message.
Some helpful links: Manual (EN) | Question Types | Workarounds
The following user(s) said Thank You: DenisChenu

Please Log in to join the conversation.

More
8 months 6 days ago #148824 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

holch wrote: There was quite a big "break" in templates from the 2.05 (now 2.5) to the 2.5x version of Limesurvey. So if you upgraded from the 2.05 branch to the 2.5x branch, then yes, this is definitely true. if it was from a version of 2.5x to 2.5x, there should be no need to update your templates I think.


I am quite sure that I had originally created the customized template under the 2.50+ version. In any case, this template had worked just fine on 2.50+ 160812, but not under 2.62.2+ 170203, so there must have been important changes in between. I plan to always refresh the template now on any upgrade. There are only 3 files I need to change, anyway, so it's not that big a deal.

Cheers...

Please Log in to join the conversation.

More
8 months 2 days ago #148916 by DenisChenu
DenisChenu replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
Hi @oleggorfinkel,

When you find the issue can you report the bug ?

We must not broke template (except for very little glitch) if we don't update API version (the 1st number).

Thanks

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand (or search sondages pro).
An error happen ? Before make a new topic : remind the Debug mode .

Please Log in to join the conversation.

More
8 months 2 days ago #148949 by lowprofile
lowprofile replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
maybe unrelated but i just reported a news_paper template bug that also affects copied templates
bugs.limesurvey.org/view.php?id=12147

Please Log in to join the conversation.

More
8 months 2 days ago #148951 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

DenisChenu wrote: Hi @oleggorfinkel,
When you find the issue can you report the bug ?
We must not broke template (except for very little glitch) if we don't update API version (the 1st number).
Thanks


Hi Denis,

The way I solved this issue was, basically, through a workaround -- starting with the fresh new template and reintroducing my (very few) changes into it. This means that I probably will never know what the real issue was that made my old template incompatible with the new version of LimeSurvey.

But, what I CAN do is give you the original 2.50+ "default" template, as well as my modified version of it (named "AtencionPlenaUV"), so that you can do a diff on the files and see what has really changed in the new version. Also, if you set my template as default, under 2.62.2+170203, you'll probably be able to actually reproduce the problem. So, I have attached the two versions of the original template here for your reference.

By the way, the only two modifications I had made to the default template were:

- changed the logo on the start page
- commented out SITENAME in the surveylist.pstpl file

Cheers,
Oleg.
Attachments:

Please Log in to join the conversation.

More
8 months 2 days ago #148952 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

lowprofile wrote: maybe unrelated but i just reported a news_paper template bug that also affects copied templates
bugs.limesurvey.org/view.php?id=12147


Hi @lowprofile,

It looks like that one is, indeed, an unrelated bug.

Cheers...

Please Log in to join the conversation.

More
8 months 1 day ago #148964 by DenisChenu
DenisChenu replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
About diff to see the update : git have a better solution : github.com/LimeSurvey/LimeSurvey/commits...er/templates/default ;)

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand (or search sondages pro).
An error happen ? Before make a new topic : remind the Debug mode .

Please Log in to join the conversation.

More
8 months 1 day ago #148966 by oleggorfinkel
oleggorfinkel replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?

DenisChenu wrote: About diff to see the update : git have a better solution : github.com/LimeSurvey/LimeSurvey/commits...er/templates/default ;)


Yep, that'll do it...

By the way, I saw this in the log: "Fixed issue #11685: Survey header in mobile view breaking into next line".

Looks like this very issue was, in fact, addressed on Oct. 20, and clearly it had first appeared some time after mid-july (which is when I upgraded to 2.50+).

The lesson in all this is that updates to the default template are happening periodically, so you can't just assume that your custom templates will remain valid from one build to another (not to mention from one VERSION to another). As a result, for people who use customized templates, it should be standard procedure on any upgrade to verify that no "default" template changes have occurred, which can be done either through the commits log, or else, with diff (my preferred option). And in the future, It would be great to see some kind of an automated template update tool.

Thanks for all your help, and all the great work you do on this project!

Cheers,
Oleg.

Please Log in to join the conversation.

More
7 months 3 weeks ago #149241 by DenisChenu
DenisChenu replied the topic: Serious bug on 2.62.2 +170203 -- quick fix, or roll back to previous version?
It's one of the reason why i added template-core package in LS 3/0/develop version : github.com/LimeSurvey/LimeSurvey/commit/...dc386a0a5ce9a6324f1b

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand (or search sondages pro).
An error happen ? Before make a new topic : remind the Debug mode .

Please Log in to join the conversation.

Start now!

Just create your account and start using Limesurvey today.

Register now