Check out the LimeSurvey source code on GitHub!

Basic CMS Integration support broken?

More
5 years 1 month ago #71402 by exnihilo
In our organisation we are using Limesurvey with the basic CMS integration that is covered in the template editor documentation :
// Set $embedded to true and specify the header and footer functions if the survey is to be displayed embedded in a CMS
 
 $embedded = false;
 $embedded_inc = "";               // path to the header to include if any
 $embedded_headerfunc = "";        // e.g. COM_siteHeader for geeklog
 $embedded_footerfunc = "";        // e.g. COM_siteFooter for geeklog

After a recent upgrade from version 186 to version 191+ the embed functionality seems to be broken. Browsing through the code of consecutive Limesurvey-versions I discovered a remarkable change in code in /limesurvey/index.php from v. 190+ to v. 191+ :

version 190+ :
if (isset($_REQUEST['embedded_inc']))
{
    safe_die('You cannot start this script directly');
}
if ( $embedded_inc != '' )
require_once( $embedded_inc );

version 191+ :
if (isset($_REQUEST['embedded_inc']))
{
    safe_die('You cannot start this script directly');
}

Two lines are deleted, the content of variable &embedded_inc is never included so $embedded_headerfunc and $embedded_footerfunc stay idle. Same story in unstable version 1.92_RC1. Is this change in code intentional, or a bug?

Thanks,

Peter

Please Log in to join the conversation.

More
5 years 1 month ago #71406 by DenisChenu
Hello,

I think the best is to post a bug report :)

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand (or search sondages pro).

Please Log in to join the conversation.

More
5 years 1 month ago - 5 years 1 month ago #71413 by exnihilo
Thank you, I just did! ( 05643 )
Last Edit: 5 years 1 month ago by exnihilo.

Please Log in to join the conversation.

More
5 years 1 month ago #71610 by Mazi
Thanks for reporting bugs, we'll have a look.


Best regards/Beste Grüße,
Dr. Marcel Minke
(Limesurvey Head of Support)
Need Help? We offer professional Limesurvey support
Contact: marcel.minke(at)survey-consulting.com'"

Please Log in to join the conversation.

Imprint                   Privacy policy         General Terms & Conditions         Revocation information and revocation form