Welcome to the LimeSurvey Community Forum

Ask the community, share ideas, and connect with other LimeSurvey users!

binary third_party?

  • caseylucas
  • caseylucas's Avatar Topic Author
  • Offline
  • New Member
  • New Member
More
5 years 5 months ago #175009 by caseylucas
binary third_party? was created by caseylucas
I noticed when i was investigating an issue with kcfinder ( bugs.limesurvey.org/view.php?id=13982 ) that the entire /third_party directory is marked as "binary" in /third_party/.gitattributes:

* binary

See commit: github.com/LimeSurvey/LimeSurvey/commit/...31d83b3663a79fd18e5e

Marking the entire tree as binary makes using 'git diff' unusable because git just says that the binary files have changed vs. showing the actual difference. So does anyone know why the entire tree should be marked as binary?
The following user(s) said Thank You: DenisChenu
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175023 by DenisChenu
Replied by DenisChenu on topic binary third_party?
Yes : totally right !

Objective was to "just" third_party to "official" release, and use extended class for LimeSurvey. But since we use own system : there are 2 solution
1. Fork each third_party (and framework, since there are own fix/update inisde) in github.com/LimeSurvey . And use this fork in third_party
2. Disable bin in this 2 directories.

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.
More
5 years 5 months ago #175041 by jelo
Replied by jelo on topic binary third_party?
Denis, is there an answer to the question "why the entire tree should be marked as binary?".

Are the solutions, you propose towards LimeSurvey developers, which control the GITHUB LimeSurvey repository? Or for caseylucas?

Thanks.

The meaning of the word "stable" for users
www.limesurvey.org/forum/development/117...ord-stable-for-users
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175047 by DenisChenu
Replied by DenisChenu on topic binary third_party?

jelo wrote: Denis, is there an answer to the question "why the entire tree should be marked as binary?".

me wrote: Objective was to "just" third_party to "official" release, and use extended class for LimeSurvey.

My english is sooooooo baaaaad :)

I think (unsure) : framework and third party must be "exactly the same than original", and can be added using composer etc … then no need to track down change : can be binary.

jelo wrote: Are the solutions, you propose towards LimeSurvey developers, which control the GITHUB LimeSurvey repository? Or for caseylucas?

For LimeSurvey GMBH team , but maybe more Menno here ?

github.com/LimeSurvey/LimeSurvey/commit/...31d83b3663a79fd18e5e

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175048 by DenisChenu
Replied by DenisChenu on topic binary third_party?

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.
  • caseylucas
  • caseylucas's Avatar Topic Author
  • Offline
  • New Member
  • New Member
More
5 years 5 months ago #175049 by caseylucas
Replied by caseylucas on topic binary third_party?
Nice. I could have done PR but wasn't sure of any other implications. Thanks.
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175051 by DenisChenu
Replied by DenisChenu on topic binary third_party?
Iwasn't sure too (and if no answer during one week : i can merge it ;) )

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.
  • c_schmitz
  • c_schmitz's Avatar
  • Offline
  • LimeSurvey GmbH Employee
  • LimeSurvey GmbH Employee
More
5 years 5 months ago #175176 by c_schmitz
Replied by c_schmitz on topic binary third_party?
Binary was introduced because of line feed issues. Some libraries come with different linefeed settings than the one we have set in Git for developing. So if you update the library it is changed and then you have to fix the line feeds which is a regular change for Git.
So we introduced the Binary command so that the libraries are not touched anymore and can be committed as-is.
So just removing the command is not a solution as it will bring up the previous issue, again.

Best regards

Carsten Schmitz
LimeSurvey project leader
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175190 by DenisChenu
Replied by DenisChenu on topic binary third_party?
OK,

When repo are on gitb : we can copy each gitattribute. github.com/yiisoft/yii/blob/master/.gitattributes

For other : did you remind a third_party with crlf linefeed ?

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.
  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • LimeSurvey Community Team
  • LimeSurvey Community Team
More
5 years 5 months ago #175471 by DenisChenu
Replied by DenisChenu on topic binary third_party?
I close the pull request,

What must be done
1. remove current .gitattribute
2. Test all third party : git checkout-index --force --all
3. See if current version have a gitattribute on one of directory (framework have one)
4. Go back to 1 with this one
5. Add and update a .gitattribute in each directory
6. Do 2 again
7. Go back to 1

Assistance on LimeSurvey forum and LimeSurvey core development are on my free time.
I'm not a LimeSurvey GmbH member, professional service on demand , plugin development .
I don't answer to private message.
The topic has been locked.

Lime-years ahead

Online-surveys for every purse and purpose