Check out the LimeSurvey source code on GitHub!
Welcome, Guest
Username: Password:
  • Page:
  • 1
  • 2

TOPIC: LS 1.92RC design issues beacuse error-wrapper is shown permanently

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73521

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

in LimeSurvey 1.92RC3 the error-wrapper div is shown permanently and the text inside is hidden. In LimeSurvey 1.91+ the error-wrapper div itself was hidden so a few people (like myself) will run into template design issue. In one of our templates we no have red lines as "question-wrapper" which is normally a "1px 1px 1px 1px color red" border which is only shown when there is an error/wrapper-message.

So my question is how to solve this problem. I'm not sure if CSS can check if a child is hidden and then hide the parent/div element.

Attached part of our survey with our "concern" template:
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73576

  • tpartner
  • tpartner's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 6122
  • Thank you received: 1357
  • Karma: 533
TMSWhite is currently revamping the way the errors/tips are displayed in 1.92 so this may be resolved in RC4 (next week?).

If not, you may be able to use Javascriopt to hide an element if it is empty or has hidden children. Although, I will need to see the results of Tom's efforts to test.
Cheers,
Tony Partner

Solutions, code and workarounds presented in these forums are given without any warranty, implied or otherwise.
Last Edit: 4 years 5 months ago by tpartner.
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73583

  • Mazi
  • Mazi's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 5974
  • Thank you received: 366
  • Karma: 260
There have been several commits for this the last 24h so with RC4 there will probably be a different way to handle it and then we should have another look.

Best regards/Beste Grüße,
Dr. Marcel Minke
(Limesurvey Head of Support)
Need Help? We offer professional Limesurvey support
Contact: marcel.minke(at)limesurvey.org'"
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73609

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
That sounds great. I think it would be nice to handle it in template.css rather than having to add a Javascript function to hide the elements.
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73611

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
vierundzwanzig-

This has been fixed in the _dev branch, and will be available in 1.92 RC4 (probably next Tuesday). If you want to try it before we release 1.92 RC4, we'd appreciate your feedback.

Here's what has changed:
(1) .input-error class is now only added to questions that have an input error
(2) .input-error is added/removed to the question at run-time (e.g. if the question starts with an error, and you fix it, the input-error class will be removed)
(3) I added the following new classes in template.css
(a) .em_num_answers - for min_answers and max_answers
(b) .em_value_range - for min/max_num_value_n and multiflexible_min/max
(c) .em_sum_range - for min/max/equals_num_value
(d) .em_regex_validation - for preg-based validation
(e) .em_q_fn_validation - for em_validation_q
(f) .em_sq_fn_validation - for em_validation_sq

These control the styling of the validation tips (such as "Please select between X and Y answers"). Each is styled and validated separately. By default, messages are shown in green if they are valid, and red if invalid (but you can control that using template.css). Furthermore, by default, (d)-(f) are hidden, since people don't tend to want to see regular expression validation messages. So, if you have a question that has min/max_answers, and value_range and sum_range, you could pass some validation criteria, but not others (e.g. you might have the right sum, but the wrong number of answers). The styling of the validation messages will let you and the users quickly see whether they have passed all validation requirements, and if not, what needs to be fixed.

So, please consider being an early adopter and try it before we release 1.92 RC4.

/Tom
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73623

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

I'll try to have a look at it. But I'm not if I can finish it until Tuesday, it depends on how many other things I have and get to do. In the best case there isn't much to do on Monday and I see what I can do.
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73637

  • Mazi
  • Mazi's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 5974
  • Thank you received: 366
  • Karma: 260
Maybe we should add those classes somewhere near docs.limesurvey.org/The+template+editor&..._of_question_classes ?!

Best regards/Beste Grüße,
Dr. Marcel Minke
(Limesurvey Head of Support)
Need Help? We offer professional Limesurvey support
Contact: marcel.minke(at)limesurvey.org'"
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73642

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
OK, updated.
The administrator has disabled public write access.

LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73651

  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • Moderator Lime
  • Posts: 9259
  • Thank you received: 1320
  • Karma: 382
And i make a lot of change for citronade too.

Tom make a lot of change too, great job \o/
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73655

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

perhaps we can use the names displayed in the advanced question settings rather than the technical name in the description at
docs.limesurvey.org/The+template+editor#...f_validation_classes
. I think it might be easier to understand using "Minimum value" than "min_num_value_n". Or we add an additional column in this table where the matching advandced option are listed.
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73659

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Hello,

I now started my little test surveys with different templates. They are available on our EM Installation (1.92RC3 build 12322 from SVN) at
212.65.8.158/limesurveyEM/

There are currently 4 "My little Test-Survey" surveys using the default, citronade and 2 customized templates created from the 1.91+ version of citronade.

If you want to have a look at the templates you can use the account
Part of the message is hidden for the guests. Please log in or register to see it.
to acess them using the template editor. Don't worry, it's a paralell installation and doesn't affect our stable running installation. So we could play a bit.
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73668

  • DenisChenu
  • DenisChenu's Avatar
  • Offline
  • Moderator Lime
  • Posts: 9259
  • Thank you received: 1320
  • Karma: 382
:(

A little problem with
div.em_q_fn_validation {
    display: none;
}
And
.js .help-wrapper > span, .js .help-wrapper > div {
    background: none repeat scroll 0 0 #FEFEFE;
    border: 1px solid #FCEFA1;
    color: #363636;
}

For So how much do you want to donate , ?

Look for a good alternative ... I like background/padding/border on tip/error/help like uijquery .ui-state-highlight

Denis
Assistance on LimeSurvey forum and LimeSurvey core developpement are on my free time (Say thanks ?).
A bug not reported is a bug not corrected. | Please, read the documentation | La doc en français à besoin de vous
Last Edit: 4 years 5 months ago by DenisChenu. Reason: oups .... Submit
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73819

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Sorry guys I'm quite late but I had some severe problems with ExprMgr_process_relevance_and_tailoring that slowed down my Firefox 10 and even loaded him to dead:
bugs.limesurvey.org/view.php?id=5771
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73848

  • TMSWhite
  • TMSWhite's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 758
  • Thank you received: 83
  • Karma: 37
vierundzwanzig-

Thanks for opening a separate bug ticket about this. If we need a discussion thread about EM performance, let's create a new thread rather than using the error-wrapper thread.


/Tom
The administrator has disabled public write access.

Aw: LS 1.92RC design issues beacuse error-wrapper is shown permanently 4 years 5 months ago #73890

  • Steve
  • Steve's Avatar
  • Offline
  • LimeSurvey Team
  • Posts: 493
  • Thank you received: 46
  • Karma: 17
Okay, let's open one if it's necessary. For now I don't see any problems (after fetching the latest version with the bugfix). It's just difficult to test a template/css if you can't reload the page.*g*

One thing that I noticed is that using
.good {color: #009900;}
is also applied to the text input if you use regex. So if you begin to write the green is used as font-color. I think it could irritate the participant if you enter something that's wrong (doesn't match the regex) and the font is always green. Lets make a short example.

Q: So how much do you want to donate ?
A1: *using green font-color* abc
*leaving the answer*
A1: *background-color now pink and font-color now black, bold text* abc
Change the text
A1: *background-color now pink and font-color now black, bold text* 120
The text enterd is shown as it would be wrong.

You (or let's say the participant without much knowledge) might think the input is validated each time you enter something so it might be confusing.

So I think it might be a good idea not to use ".good", ".problem" and ".error" without adressing the correct HTML element (e.g. "span.hide-tip").
Mit freundlichen Grüßen/Best regards,

Stefan Gohlke
LimeSurvey Team
The administrator has disabled public write access.
  • Page:
  • 1
  • 2
Moderators: ITEd
Time to create page: 0.574 seconds
Imprint                   Data Protection Statement                  Revocation information and revocation form