Welcome, Guest
Username: Password: Remember me

TOPIC: Basic CMS Integration support broken?

Basic CMS Integration support broken? 2 years 7 months ago #71402

  • exnihilo
  • exnihilo's Avatar
  • OFFLINE
  • Fresh Lemon
  • Posts: 2
  • Karma: 0
In our organisation we are using Limesurvey with the basic CMS integration that is covered in the template editor documentation:
// Set $embedded to true and specify the header and footer functions if the survey is to be displayed embedded in a CMS
 
 $embedded = false;
 $embedded_inc = "";               // path to the header to include if any
 $embedded_headerfunc = "";        // e.g. COM_siteHeader for geeklog
 $embedded_footerfunc = "";        // e.g. COM_siteFooter for geeklog

After a recent upgrade from version 186 to version 191+ the embed functionality seems to be broken. Browsing through the code of consecutive Limesurvey-versions I discovered a remarkable change in code in /limesurvey/index.php from v. 190+ to v. 191+ :

version 190+ :
if (isset($_REQUEST['embedded_inc']))
{
    safe_die('You cannot start this script directly');
}
if ( $embedded_inc != '' )
require_once( $embedded_inc );

version 191+ :
if (isset($_REQUEST['embedded_inc']))
{
    safe_die('You cannot start this script directly');
}

Two lines are deleted, the content of variable &embedded_inc is never included so $embedded_headerfunc and $embedded_footerfunc stay idle. Same story in unstable version 1.92_RC1. Is this change in code intentional, or a bug?

Thanks,

Peter
The administrator has disabled public write access.

Re: Basic CMS Integration support broken? 2 years 7 months ago #71406

  • DenisChenu
  • DenisChenu's Avatar
  • OFFLINE
  • Moderator Lime
  • Posts: 6276
  • Thank you received: 801
  • Karma: 241
Hello,

I think the best is to post a bug report :)
The administrator has disabled public write access.

Re: Basic CMS Integration support broken? 2 years 7 months ago #71413

  • exnihilo
  • exnihilo's Avatar
  • OFFLINE
  • Fresh Lemon
  • Posts: 2
  • Karma: 0
Thank you, I just did! (05643)
Last Edit: 2 years 7 months ago by exnihilo.
The administrator has disabled public write access.

Re: Basic CMS Integration support broken? 2 years 7 months ago #71610

  • Mazi
  • Mazi's Avatar
  • OFFLINE
  • LimeSurvey Team
  • Posts: 5324
  • Thank you received: 294
  • Karma: 249
Thanks for reporting bugs, we'll have a look.

Best regards/Beste Grüße,
Dr. Marcel Minke
(Limesurvey Head of Support)
Need Help? We offer professional Limesurvey support
Contact: marcel.minke(at)limesurvey.org'"
The administrator has disabled public write access.
Moderators: ITEd
Time to create page: 0.276 seconds
Donation Image